feat(linter): Add suggested fix to typescript/no_unnecessary_parameter_property_assignment and fix false positive#9973
Merged
shulaoda merged 2 commits intooxc-project:mainfrom Mar 24, 2025
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
CodSpeed Instrumentation Performance ReportMerging #9973 will not alter performanceComparing Summary
|
ulrichstark
commented
Mar 22, 2025
crates/oxc_linter/src/rules/typescript/no_unnecessary_parameter_property_assignment.rs
Show resolved
Hide resolved
shulaoda
approved these changes
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just added a suggested fix to the lint rule as continuation of my work in #9720 and #9618.
The original typescript-eslint rule isn't capable of fixing its reported issue, but the fix should be pretty safe.
I decided to configure it as
suggestionand not as 100% safefix.Also found one false positive while implementing the fix suggestion, fixed it and added a corresponding passing test.