feat(oxc_semantic): make Scoping cloneable

[IWANABETHATGUY]

No description provided.

[IWANABETHATGUY]

• feat(oxc_semantic): make Scoping cloneable #9953 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[IWANABETHATGUY]

Scoping clone is used in https://github.com/rolldown/rolldown/pull/3923/files#diff-6918bafb253daefceb5bea2032b19397ae55a063ea5492156ecc011e51af2e8dR9

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #9953 will not alter performance

_{Comparing 03-21-feat_make_scoping_cloneable (b4f3d00) with main (ea3de06)}

Summary

✅ 33 untouched benchmarks

[overlookmotel]

Do you really need to clone Scoping? That is a very expensive operation. (That's just a question, not a criticism)

Also, I think Allocator::used_bytes is the method you need to get an appropriate capacity. Allocator::capacity will likely be excessive. See the doc comments on the 2 methods to understand the difference.

I designed Allocator::used_bytes just for you!

[IWANABETHATGUY]

Do you really need to clone Scoping? That is a very expensive operation. (That's just a question, not a criticism)

Also, I think Allocator::used_bytes is the method you need to get an appropriate capacity. Allocator::capacity will likely be excessive. See the doc comments on the 2 methods to understand the difference.

I designed Allocator::used_bytes just for you!

Yeah, it is used for incremental build, since rolldown mutate the scoping, we need to clone the scoping at the first time to make sure it could be used in second round, I will try to eliminate it in the future, but for now there is no alternative way.

[Boshen]

Merge activity

• Mar 23, 5:09 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 23, 5:09 AM EDT: A user added this pull request to the Graphite merge queue.
• Mar 23, 9:11 AM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.
• Mar 23, 5:12 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 23, 5:20 AM EDT: A user added this pull request to the Graphite merge queue.
• Mar 23, 5:32 AM EDT: A user merged this pull request with the Graphite merge queue.