Skip to content

perf(regular_expression): make all fieldless enums Copy #9937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 21, 2025
Merged

perf(regular_expression): make all fieldless enums Copy #9937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/oxc_regular_expression/src/ast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ pub struct BoundaryAssertion {
}

#[ast]
#[derive(Debug, Clone, PartialEq, Eq)]
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
#[generate_derive(CloneIn, ContentEq, ESTree)]
pub enum BoundaryAssertionKind {
Start = 0,
Expand All @@ -104,7 +104,7 @@ pub struct LookAroundAssertion<'a> {
}

#[ast]
#[derive(Debug, Clone, PartialEq, Eq)]
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
#[generate_derive(CloneIn, ContentEq, ESTree)]
pub enum LookAroundAssertionKind {
Lookahead = 0,
Expand Down Expand Up @@ -217,7 +217,7 @@ pub struct CharacterClass<'a> {
}

#[ast]
#[derive(Debug, PartialEq, Eq)]
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
#[generate_derive(CloneIn, ContentEq, ESTree)]
pub enum CharacterClassContentsKind {
Union = 0,
Expand Down
6 changes: 3 additions & 3 deletions crates/oxc_regular_expression/src/parser/pattern_parser/pattern_parser_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ impl<'a> PatternParser<'a> {
let (kind, body) = self.parse_class_contents()?;

if self.reader.eat(']') {
let strings = PatternParser::may_contain_strings_in_class_contents(&kind, &body);
let strings = PatternParser::may_contain_strings_in_class_contents(kind, &body);

// [SS:EE] CharacterClass :: [^ ClassContents ]
// It is a Syntax Error if MayContainStrings of the ClassContents is true.
Expand Down Expand Up @@ -1321,7 +1321,7 @@ impl<'a> PatternParser<'a> {
let (kind, body) = self.parse_class_contents()?;

if self.reader.eat(']') {
let strings = PatternParser::may_contain_strings_in_class_contents(&kind, &body);
let strings = PatternParser::may_contain_strings_in_class_contents(kind, &body);

// [SS:EE] NestedClass :: [^ ClassContents ]
// It is a Syntax Error if MayContainStrings of the ClassContents is true.
Expand Down Expand Up @@ -2307,7 +2307,7 @@ impl<'a> PatternParser<'a> {
// ---

fn may_contain_strings_in_class_contents(
kind: &ast::CharacterClassContentsKind,
kind: ast::CharacterClassContentsKind,
body: &Vec<'a, ast::CharacterClassContents<'a>>,
) -> bool {
let may_contain_strings = |item: &ast::CharacterClassContents<'a>| match item {
Expand Down
Loading