Skip to content

refactor(transformer): construct new AST instead of calling ast.clone_in() #9916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 21, 2025
Merged

refactor(transformer): construct new AST instead of calling ast.clone_in() #9916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_transformer/src/common/duplicate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ impl<'a> TransformCtx<'a> {
let references = create_array(|| {
ctx.ast.expression_template_literal(
lit.span,
lit.quasis.clone_in(ctx.ast.allocator),
ctx.ast.vec_from_iter(lit.quasis.iter().cloned()),
ctx.ast.vec(),
)
});
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_transformer/src/es2016/exponentiation_operator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ impl<'a> ExponentiationOperator<'a, '_> {
// obj.#prop = Math.pow(obj.#prop, right)
// ^^^^^
// ```
let field = field_expr.field.clone_in(ctx.ast.allocator);
let field = field_expr.field.clone();

// Complete 2nd member expression
// ```
Expand Down
6 changes: 4 additions & 2 deletions crates/oxc_transformer/src/es2018/object_rest_spread.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ use std::mem;

use serde::Deserialize;

use oxc_allocator::{CloneIn, GetAddress, Vec as ArenaVec};
use oxc_allocator::{GetAddress, Vec as ArenaVec};
use oxc_ast::{NONE, ast::*};
use oxc_diagnostics::OxcDiagnostic;
use oxc_ecmascript::{
Expand Down Expand Up @@ -979,7 +979,9 @@ impl<'a> ObjectRestSpread<'a, '_> {
}
// `let { [`a`], ... rest }`
PropertyKey::TemplateLiteral(lit) if lit.is_no_substitution_template() => {
let expr = Expression::TemplateLiteral(lit.clone_in(ctx.ast.allocator));
let quasis = ctx.ast.vec1(lit.quasis[0].clone());
let expressions = ctx.ast.vec();
let expr = ctx.ast.expression_template_literal(lit.span, quasis, expressions);
Some(ArrayExpressionElement::from(expr))
}
PropertyKey::PrivateIdentifier(_) => {
Expand Down