Skip to content

fix(linter/react): exhaustive-deps report longest dependency #9891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 20, 2025
Merged

fix(linter/react): exhaustive-deps report longest dependency #9891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion crates/oxc_linter/src/rules/react/exhaustive_deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,13 @@ impl Rule for ExhaustiveDeps {
// for example if `props.foo`, AND `props.foo.bar.baz` was declared in the deps array
// `props.foo.bar.baz` is unnecessary (already covered by `props.foo`)
declared_dependencies.iter().tuple_combinations().for_each(|(a, b)| {
if a.contains(b) || b.contains(a) {
if a.contains(b) {
ctx.diagnostic(unnecessary_dependency_diagnostic(
hook_name,
&a.to_string(),
dependencies_node.span,
));
} else if b.contains(a) {
ctx.diagnostic(unnecessary_dependency_diagnostic(
hook_name,
&b.to_string(),
Expand Down Expand Up @@ -2362,6 +2368,13 @@ fn test() {
console.log(props.bar);
}, [props, props.foo]);
}",
r"function MyComponent(props) {
const local = {};
useCallback(() => {
console.log(props.foo);
console.log(props.bar);
}, [props.foo, props]);
}",
r"function MyComponent(props) {
const local = {};
useCallback(() => {
Expand Down
13 changes: 11 additions & 2 deletions crates/oxc_linter/src/snapshots/react_exhaustive_deps.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Extract the expression to a separate variable so it can be statically checked.

⚠ eslint-plugin-react(exhaustive-deps): React Hook useCallback has unnecessary dependency: props
⚠ eslint-plugin-react(exhaustive-deps): React Hook useCallback has unnecessary dependency: props.foo
╭─[exhaustive_deps.tsx:6:14]
5 │ console.log(props.bar);
6 │ }, [props, props.foo]);
Expand All @@ -523,6 +523,15 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Either include it or remove the dependency array.

⚠ eslint-plugin-react(exhaustive-deps): React Hook useCallback has unnecessary dependency: props.foo
╭─[exhaustive_deps.tsx:6:14]
5 │ console.log(props.bar);
6 │ }, [props.foo, props]);
· ──────────────────
7 │ }
╰────
help: Either include it or remove the dependency array.

⚠ eslint-plugin-react-hooks(exhaustive-deps): React Hook useCallback has missing dependencies: 'props.foo', and 'props.bar'
╭─[exhaustive_deps.tsx:6:14]
5 │ console.log(props.bar);
Expand Down Expand Up @@ -559,7 +568,7 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Either include it or remove the dependency array.

⚠ eslint-plugin-react(exhaustive-deps): React Hook useCallback has unnecessary dependency: local
⚠ eslint-plugin-react(exhaustive-deps): React Hook useCallback has unnecessary dependency: local.id
╭─[exhaustive_deps.tsx:5:14]
4 │ console.log(local);
5 │ }, [local.id, local]);
Expand Down