Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/oxc_minifier/src/options.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@ pub struct CompressOptions {
#[expect(clippy::derivable_impls)]
impl Default for CompressOptions {
fn default() -> Self {
Self { drop_console: false, ..Self::all_true() }
Self { drop_console: false, ..Self::smallest() }
}
}

impl CompressOptions {
pub fn all_true() -> Self {
pub fn smallest() -> Self {
Self { target: ESTarget::ESNext, drop_debugger: true, drop_console: true }
}

pub fn all_false() -> Self {
pub fn safest() -> Self {
Self { target: ESTarget::ESNext, drop_debugger: false, drop_console: false }
}
}
2 changes: 1 addition & 1 deletion crates/oxc_minifier/src/tester.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ pub fn test_same(source_text: &str) {
}

pub fn test(source_text: &str, expected: &str) {
let result = run(source_text, Some(CompressOptions::all_true()));
let result = run(source_text, Some(CompressOptions::smallest()));
let expected = run(expected, None);
assert_eq!(result, expected, "\nfor source\n{source_text}\nexpect\n{expected}\ngot\n{result}");
}
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_minifier/tests/peephole/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ mod esbuild;
use oxc_minifier::CompressOptions;

fn test(source_text: &str, expected: &str) {
let options = CompressOptions::all_false();
let options = CompressOptions::safest();
crate::test(source_text, expected, options);
}

Expand Down
4 changes: 2 additions & 2 deletions napi/playground/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,10 @@ impl Oxc {
CompressOptions {
drop_console: compress_options.drop_console,
drop_debugger: compress_options.drop_debugger,
..CompressOptions::all_false()
..CompressOptions::safest()
}
} else {
CompressOptions::all_false()
CompressOptions::safest()
}),
};
Minifier::new(options).build(&allocator, &mut program).scoping
Expand Down
2 changes: 1 addition & 1 deletion tasks/benchmark/benches/minifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ fn bench_minifier(criterion: &mut Criterion) {
let mut program = Parser::new(&allocator, source_text, source_type).parse().program;
let scoping = SemanticBuilder::new().build(&program).semantic.into_scoping();

let options = CompressOptions::all_true();
let options = CompressOptions::smallest();

runner.run(|| {
Compressor::new(&allocator, options).build_with_scoping(scoping, &mut program);
Expand Down
2 changes: 1 addition & 1 deletion tasks/coverage/src/driver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ impl CompilerInterface for Driver {
}

fn compress_options(&self) -> Option<CompressOptions> {
self.compress.then(CompressOptions::all_true)
self.compress.then(CompressOptions::smallest)
}

fn codegen_options(&self) -> Option<CodegenOptions> {
Expand Down
Loading