perf(ast): re-order VariableDeclarationKind variants#9853
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 18, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #9853 will not alter performanceComparing Summary
|
Member
Author
|
@camc314 In case you're interested, this relates to your question #9751 (comment). But this is a micro micro optimization. Only saves a couple of instructions, which is a drop in ocean. |
camc314
approved these changes
Mar 18, 2025
Contributor
|
all the drops add up 🙂 |
Contributor
Merge activity
|
Micro-optimization. Re-order variants of `VariableDeclarationKind`. With this order: * Checking if it's a lexical declaration is `discriminant != 0` * Checking if it's const is `discriminant > 1`. The latter is a couple of instructions shorter than it was before (`discriminant == 1 || discriminant > 2`).
graphite-app
bot
force-pushed
the
03-18-perf_ast_re-order_variabledeclarationkind_variants
branch
from
4f08f42 to
2d63704
Compare
graphite-app
bot
deleted the
03-18-perf_ast_re-order_variabledeclarationkind_variants
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Micro-optimization.
Re-order variants of
VariableDeclarationKind. With this order:discriminant != 0discriminant > 1.The latter is a couple of instructions shorter than it was before (
discriminant == 1 || discriminant > 2).