feat(data_structures)!: put all parts behind features#9849
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 18, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-semantic
CodSpeed Performance ReportMerging #9849 will not alter performanceComparing Summary
|
Member
Merge activity
|
Put all parts of `oxc_data_structures` crate behind features. `oxc_data_structures` is intended to be a "kitchen sink" crate where any data structures which are shared between multiple crates can go. We want to avoid having tons of little crates `oxc_rope`, `oxc_stack` etc. But this means it'll inevitably grow over time, and that will impact compile times. Feature-gating each part of the crate should prevent compile times suffering as `oxc_data_structures` grows. The immediate benefit is it removes the `ropey` dependency from `oxc_ast` and various other crates.
graphite-app
bot
force-pushed
the
03-18-feat_data_structures_put_all_parts_behind_features
branch
from
4e6a4e5 to
b3ce925
Compare
graphite-app
bot
deleted the
03-18-feat_data_structures_put_all_parts_behind_features
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put all parts of
oxc_data_structurescrate behind features.oxc_data_structuresis intended to be a "kitchen sink" crate where any data structures which are shared between multiple crates can go. We want to avoid having tons of little cratesoxc_rope,oxc_stacketc. But this means it'll inevitably grow over time, and that will impact compile times.Feature-gating each part of the crate should prevent compile times suffering as
oxc_data_structuresgrows.The immediate benefit is it removes the
ropeydependency fromoxc_astand various other crates.