Skip to content

refactor(napi): disable unused browser fs#9848

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-18-refactor_napi_parser_disable_unused_browser_fs
Mar 18, 2025
Merged

refactor(napi): disable unused browser fs#9848
graphite-app[bot] merged 1 commit intomainfrom
03-18-refactor_napi_parser_disable_unused_browser_fs

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 18, 2025

I don't think file access is needed for napi packages. I've already disabled this on napi/playground.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 18, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hi-ogawa hi-ogawa changed the title refactor(napi/parser): disable unused browser fs refactor(napi): disable unused browser fs Mar 18, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review March 18, 2025 05:50
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
Copy link
Member

Boshen commented Mar 18, 2025

Merge activity

  • Mar 18, 1:52 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 18, 1:52 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 18, 2:07 AM EDT: A user merged this pull request with the Graphite merge queue.

I don't think file access is needed for napi packages. I've already disabled this on napi/playground.
@graphite-app graphite-app bot force-pushed the 03-18-refactor_napi_parser_disable_unused_browser_fs branch from 002e513 to 7106e5d Compare March 18, 2025 05:53
@graphite-app graphite-app bot merged commit 7106e5d into main Mar 18, 2025
14 checks passed
@graphite-app graphite-app bot deleted the 03-18-refactor_napi_parser_disable_unused_browser_fs branch March 18, 2025 06:07
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants