Skip to content

perf(minify): use mimalloc-safe to replace mimalloc#9810

Merged
Boshen merged 1 commit intomainfrom
03-16-perf_use_mimalloc-safe_to_replace_mimalloc
Mar 17, 2025
Merged

perf(minify): use mimalloc-safe to replace mimalloc#9810
Boshen merged 1 commit intomainfrom
03-16-perf_use_mimalloc-safe_to_replace_mimalloc

Conversation

@Brooooooklyn
Copy link
Member

@Brooooooklyn Brooooooklyn commented Mar 16, 2025

This is maintained by us, and it's upgraded to mimalloc 2.2.2. This pr also adds mimalloc to oxc-minify

This is maintained by us, and it's upgraded to mimalloc 2.2.2.
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-cli Area - CLI label Mar 16, 2025
@Brooooooklyn Brooooooklyn changed the title perf: use mimalloc-safe to replace mimalloc perf(minify): use mimalloc-safe to replace mimalloc Mar 16, 2025
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Mar 16, 2025
@Brooooooklyn Brooooooklyn requested a review from Boshen March 16, 2025 15:23
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #9810 will not alter performance

Comparing 03-16-perf_use_mimalloc-safe_to_replace_mimalloc (31c407d) with main (4e39ba0)

Summary

✅ 33 untouched benchmarks

@Brooooooklyn
Copy link
Member Author

There is about 9% performance boost on my Linux

Before

❯ pnpm bench -a typescript -m oxc-minify

> minification-benchmarks@ bench /home/lyn/workspace/github/minification-benchmarks
> tsx packages/bench/benchmark/cli.ts "-a" "typescript" "-m" "oxc-minify"

{"data":{"minifiedBytes":3349566,"minzippedBytes":860673,"time":346.58113}}

After:

❯ pnpm bench -a typescript -m oxc-minify

> minification-benchmarks@ bench /home/lyn/workspace/github/minification-benchmarks
> tsx packages/bench/benchmark/cli.ts "-a" "typescript" "-m" "oxc-minify"

{"data":{"minifiedBytes":3349566,"minzippedBytes":860673,"time":318.14663}}

@Boshen Boshen merged commit 84fa538 into main Mar 17, 2025
28 of 29 checks passed
@Boshen Boshen deleted the 03-16-perf_use_mimalloc-safe_to_replace_mimalloc branch March 17, 2025 04:38
This was referenced Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants