Skip to content

feat(oxc_linter): Sort rules by plugin and rule name when outputting resolved config as a JSON string #9799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 2 commits into from
Mar 16, 2025
Merged

feat(oxc_linter): Sort rules by plugin and rule name when outputting resolved config as a JSON string #9799

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
151ca67
feat(oxc_linter): Sort rules by plugin and rule name when outputting …
nrayburn-tech Mar 15, 2025
81e3a10
u
Boshen Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/oxc_linter/src/config/config_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
use itertools::Itertools;
use oxc_diagnostics::OxcDiagnostic;
use oxc_span::CompactStr;
use rustc_hash::FxHashSet;
Comment thread
Boshen marked this conversation as resolved.
Outdated
use std::{
cell::{Ref, RefCell},
fmt,
};

use oxc_diagnostics::OxcDiagnostic;
use oxc_span::CompactStr;
use rustc_hash::FxHashSet;

use crate::{
AllowWarnDeny, LintConfig, LintFilter, LintFilterKind, Oxlintrc, RuleCategory, RuleEnum,
RuleWithSeverity,
Expand Down Expand Up @@ -326,6 +326,7 @@ impl ConfigStoreBuilder {
let new_rules = self
.rules
.iter()
.sorted_by_key(|x| format!("{}/{}", x.plugin_name(), x.name()))
Comment thread
Boshen marked this conversation as resolved.
Outdated
.map(|r: &RuleWithSeverity| ESLintRule {
plugin_name: r.plugin_name().to_string(),
rule_name: r.rule.name().to_string(),
Expand Down