Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
4cbd262 to
acfdb77
Compare
0d2f001 to
db3574b
Compare
a296d7f to
a4237d2
Compare
db3574b to
5bf345c
Compare
Base automatically changed from
03-09-feat_napi_parser_json.parse_the_returned_ast
to
main
March 18, 2025 03:31
2d5e342 to
a7bf868
Compare
a7bf868 to
4990961
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds (almost) e2e testing of
oxc-parseron browser using Vitest browser mode.How to test locally:
I said "almost" because this doesn't test the exact scenario when
oxc-parserand@oxc-parser/binding-wasm32-wasiare installed undernode_modules, which can cause bundlers to behavior differently (especially Vite unbundled dev). Nonetheless, this should verify functional napi-rs setup for browser. I think we can separately create a sample Vite app on stackblitz for doc purpose, which requiresoptimizeDeps.excludeand other gotchas.todo