Skip to content

refactor(linter): improve typescript-no-misused-new #9766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 2 commits into from
Mar 14, 2025
Merged

refactor(linter): improve typescript-no-misused-new #9766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6b45bf
Remove if let nesting
therewillbecode Mar 13, 2025
395d6e7
Add correctness examples in docs
therewillbecode Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 53 additions & 34 deletions crates/oxc_linter/src/rules/typescript/no_misused_new.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ pub struct NoMisusedNew;
declare_oxc_lint!(
/// ### What it does
///
/// Enforce valid definition of `new` and `constructor`
/// Enforces valid definition of new and constructor. This rule prevents classes from defining
/// a method named `new` and interfaces from defining a method named `constructor`.
///
/// ### Why is this bad?
///
Expand All @@ -38,17 +39,34 @@ declare_oxc_lint!(
/// Developers new to JavaScript classes and/or TypeScript interfaces may
/// sometimes confuse when to use constructor or new.
///
/// ### Example
/// ### Examples
///
/// Examples of **incorrect** code for this rule:
/// ```typescript
/// declare class C {
/// new(): C;
/// }
/// ```
///
/// ```typescript
/// interface I {
/// new (): I;
/// constructor(): void;
/// }
/// ```
///
/// Examples of **correct** code for this rule:
/// ```typescript
/// declare class C {
/// constructor();
/// }
/// ```
///
/// ```typescript
/// interface I {
/// new (): C;
/// }
/// ```
NoMisusedNew,
typescript,
correctness
Expand All @@ -61,18 +79,21 @@ impl Rule for NoMisusedNew {
let decl_name = &interface_decl.id.name;

for signature in &interface_decl.body.body {
if let TSSignature::TSConstructSignatureDeclaration(sig) = signature {
if let Some(return_type) = &sig.return_type {
if let TSType::TSTypeReference(type_ref) = &return_type.type_annotation
{
if let TSTypeName::IdentifierReference(id) = &type_ref.type_name {
if id.name == decl_name {
ctx.diagnostic(no_misused_new_interface_diagnostic(
Span::new(sig.span.start, sig.span.start + 3),
));
}
}
}
let TSSignature::TSConstructSignatureDeclaration(sig) = signature else {
continue;
};
let Some(return_type) = &sig.return_type else {
continue;
};
let TSType::TSTypeReference(type_ref) = &return_type.type_annotation else {
continue;
};
if let TSTypeName::IdentifierReference(id) = &type_ref.type_name {
if id.name == decl_name {
ctx.diagnostic(no_misused_new_interface_diagnostic(Span::new(
sig.span.start,
sig.span.start + 3,
)));
}
}
}
Expand All @@ -85,27 +106,25 @@ impl Rule for NoMisusedNew {
}
}
AstKind::Class(cls) => {
if let Some(cls_id) = &cls.id {
let cls_name = &cls_id.name;
let Some(cls_id) = &cls.id else {
return;
};
let cls_name = &cls_id.name;

for element in &cls.body.body {
if let ClassElement::MethodDefinition(method) = element {
if method.key.is_specific_id("new") && method.value.body.is_none() {
if let Some(return_type) = &method.value.return_type {
if let TSType::TSTypeReference(type_ref) =
&return_type.type_annotation
{
if let TSTypeName::IdentifierReference(current_id) =
&type_ref.type_name
{
if current_id.name == cls_name {
ctx.diagnostic(no_misused_new_class_diagnostic(
method.key.span(),
));
}
}
}
}
for element in &cls.body.body {
let ClassElement::MethodDefinition(method) = element else {
continue;
};
if method.key.is_specific_id("new") && method.value.body.is_none() {
let Some(return_type) = &method.value.return_type else {
continue;
};
let TSType::TSTypeReference(type_ref) = &return_type.type_annotation else {
continue;
};
if let TSTypeName::IdentifierReference(current_id) = &type_ref.type_name {
if current_id.name == cls_name {
ctx.diagnostic(no_misused_new_class_diagnostic(method.key.span()));
}
}
}
Expand Down