Skip to content

refactor(linter): Remove if let nesting from nextjs-no-async-client-component #9764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shulaoda merged 1 commit into from
Mar 13, 2025
Merged

refactor(linter): Remove if let nesting from nextjs-no-async-client-component #9764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 36 additions & 33 deletions crates/oxc_linter/src/rules/nextjs/no_async_client_component.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,43 +63,46 @@ impl Rule for NoAsyncClientComponent {
}

// async function MyComponent() {...}; export default MyComponent;
if let ExportDefaultDeclarationKind::Identifier(export_default_id) =
let ExportDefaultDeclarationKind::Identifier(export_default_id) =
&export_default_decl.declaration
{
let Some(decl) = get_declaration_of_variable(export_default_id, ctx) else {
continue;
};
else {
continue;
};
let Some(decl) = get_declaration_of_variable(export_default_id, ctx) else {
continue;
};

if let AstKind::Function(func) = decl.kind() {
if func.r#async
&& func
.id
.as_ref()
// `func.id.name` MUST be > 0 chars
.is_some_and(|v| v.name.chars().next().unwrap().is_uppercase())
{
ctx.diagnostic(no_async_client_component_diagnostic(
func.id.as_ref().unwrap().span,
));
}
if let AstKind::Function(func) = decl.kind() {
if func.r#async
&& func
.id
.as_ref()
// `func.id.name` MUST be > 0 chars
.is_some_and(|v| v.name.chars().next().unwrap().is_uppercase())
{
ctx.diagnostic(no_async_client_component_diagnostic(
func.id.as_ref().unwrap().span,
));
}
}

let AstKind::VariableDeclarator(var_declarator) = decl.kind() else {
continue;
};

if let AstKind::VariableDeclarator(var_declarator) = decl.kind() {
if let BindingPatternKind::BindingIdentifier(binding_ident) =
&var_declarator.id.kind
{
// `binding_ident.name` MUST be > 0 chars
if binding_ident.name.chars().next().unwrap().is_uppercase() {
if let Some(Expression::ArrowFunctionExpression(arrow_expr)) =
&var_declarator.init
{
if arrow_expr.r#async {
ctx.diagnostic(no_async_client_component_diagnostic(
binding_ident.span,
));
}
}
}
let BindingPatternKind::BindingIdentifier(binding_ident) = &var_declarator.id.kind
else {
continue;
};
// `binding_ident.name` MUST be > 0 chars
if binding_ident.name.chars().next().unwrap().is_uppercase() {
if let Some(Expression::ArrowFunctionExpression(arrow_expr)) =
&var_declarator.init
{
if arrow_expr.r#async {
ctx.diagnostic(no_async_client_component_diagnostic(
binding_ident.span,
));
}
}
}
Expand Down