feat(allocator)!: remove Vec::into_boxed_slice method#9735
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 13, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
b32469a to
0c0a644
Compare
CodSpeed Performance ReportMerging #9735 will not alter performanceComparing Summary
|
overlookmotel
approved these changes
Mar 13, 2025
Vec::into_boxed_slice methodVec::into_boxed_slice method
Member
Merge activity
|
related: #9656 (comment) This method blocks us from replacing the allocator-api2's `Vec` with our own `Vec`(now called `Vec2`) in #9656, considering no use cases for this method, just remove it instead. After our own `Vec` is feature-complete, we can consider making https://github.com/oxc-project/oxc/blob/b32469a458b36097162e45c8ab20327d46867c7f/crates/oxc_allocator/src/vec2/mod.rs#L1686-L1719 this work.
0c0a644 to
f2b0cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

related: #9656 (comment)
This method blocks us from replacing the allocator-api2's
Vecwith our ownVec(now calledVec2) in #9656, considering no use cases for this method, just remove it instead. After our ownVecis feature-complete, we can consider makingoxc/crates/oxc_allocator/src/vec2/mod.rs
Lines 1686 to 1719 in b32469a