test(transformer/using): alter test to demonstrate semantic mismatch#9700
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 13, 2025
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
@camc314 I think using Note: Re-parenting all child scopes of the |
overlookmotel
force-pushed
the
03-12-test_transformer_using_alter_test_to_demonstrate_semantic_mismatch
branch
from
98e49ed to
44419ee
Compare
Contributor
Merge activity
|
…9700) Where a `for (using x of ...)` statement has a single statement as its body, `enter_for_of_statement` wraps that statement in a `BlockStatement`. This introduces a new scope. We are missing logic to re-parent any scopes within that statement to be children of the new block scope. This PR alters one of the tests to demonstrate this problem.
graphite-app
bot
force-pushed
the
03-12-test_transformer_using_alter_test_to_demonstrate_semantic_mismatch
branch
from
44419ee to
bc6dbe4
Compare
graphite-app
bot
deleted the
03-12-test_transformer_using_alter_test_to_demonstrate_semantic_mismatch
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where a
for (using x of ...)statement has a single statement as its body,enter_for_of_statementwraps that statement in aBlockStatement. This introduces a new scope. We are missing logic to re-parent any scopes within that statement to be children of the new block scope.This PR alters one of the tests to demonstrate this problem.