refactor(transformer/using): remove .into()#9675
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 11, 2025
Merged
Conversation
This was referenced Mar 11, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 11, 2025
CodSpeed Performance ReportMerging #9675 will not alter performanceComparing Summary
|
camc314
approved these changes
Mar 11, 2025
ccde3da to
fc25c3b
Compare
c1c03c8 to
a4fed5a
Compare
Contributor
Merge activity
|
a4fed5a to
786b7dc
Compare
Base automatically changed from
03-11-refactor_transformer_using_shorten_astbuilder_calls
to
main
March 11, 2025 10:26
786b7dc to
21859ca
Compare
21859ca to
076d872
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-on after #9310. Pure refactor. Replace
.into()calls with more explicitExpression::frometc. This syntax is longer, but personally I find it clearer. When I see.into(), I always find myself wondering "but into what?".