feat(linter): Add eslint/no-lonely-if#9660
Merged
camchenry merged 8 commits intooxc-project:mainfrom Mar 13, 2025
Merged
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #9660 will not alter performanceComparing Summary
|
camchenry
reviewed
Mar 12, 2025
Contributor
Author
|
Thanks so much for the review @camchenry. I have implemented all the feedback so far. |
camchenry
approved these changes
Mar 13, 2025
Member
camchenry
left a comment
camchenry
left a comment
There was a problem hiding this comment.
looks good! I had a small recommendation for the span creation as well and the check order, but otherwise looks good to merge to me
camchenry
approved these changes
Mar 13, 2025
Member
|
Thanks for the contribution! |
Contributor
Author
My pleasure. Thanks again for the helpful review. @camchenry |
Boshen
added a commit
that referenced
this pull request
Mar 16, 2025
## [0.16.0] - 2025-03-16 - 225e266 linter: [**BREAKING**] Enable `--experimental-nested-config` by default and add `--disable-nested-config` option (#9760) (camchenry) ### Features - 27d6e9b editor: Only watch .oxlintrc.json or user supplied config paths (#9731) (Nicholas Rayburn) - 8dd6809 linter: Add `eslint/no-lonely-if` (#9660) (therewillbecode) - c22276e oxc_linter: Sort rules by plugin and rule name when outputting resolved config as a JSON string (#9799) (Nicholas Rayburn) ### Bug Fixes - 22f18ac linter: Improve `jsx-a11y/anchor-ambiguous-text` diagnostic message (#9789) (1zumii) - 6c11740 linter: False positive in `unicorn/catch-error-name` (#9763) (shulaoda) ### Documentation - ea6b6d9 linter: Improve docs for `eslint-valid-typeof` (#9797) (therewillbecode) - 2c48fba linter: Fix typo in `oxc/bad-min-max-func` (#9791) (Flo) - 210b876 linter: Improve `eslint-no-async-promise-executor` (#9778) (therewillbecode) - f8628bc linter: Improve `eslint-no-class-assign` (#9779) (therewillbecode) - faca7a8 linter: Improve `eslint-no-self-assign` (#9768) (therewillbecode) ### Refactor - 227d203 linter: Improve `typescript-no-unnecessary-type-constraint` (#9798) (therewillbecode) - 05fe2cd linter: Use `is_lexical` when checking for lexical decl (#9781) (camc314) - fcdd810 linter: Remove if let nesting from `unicorn-no-date-clone` (#9767) (therewillbecode) - 5a9e1b9 linter: Improve `typescript-no-misused-new` (#9766) (therewillbecode) - 9df5565 linter: Improve `unicorn/filename-case` (#9762) (shulaoda) - b0b1f18 linter: Remove if let nesting from `nextjs-no-async-client-component` (#9764) (therewillbecode) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #479 .
Rule details: https://eslint.org/docs/latest/rules/no-lonely-if