Skip to content

fix(parser): parse @__NO_SIDE_EFFECTS__ between export default and async function #9514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Mar 3, 2025
Merged

fix(parser): parse @__NO_SIDE_EFFECTS__ between export default and async function #9514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/oxc_codegen/src/gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ impl Gen for Statement<'_> {
Self::FunctionDeclaration(decl) => {
p.print_statement_comments(decl.span.start);
if decl.pure && p.options.print_annotation_comments() {
p.print_indent();
p.print_str(NO_SIDE_EFFECTS_NEW_LINE_COMMENT);
}
p.print_indent();
Expand Down
2 changes: 2 additions & 0 deletions crates/oxc_codegen/tests/integration/pure_comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ async function* d() {}
/* @__NO_SIDE_EFFECTS__ */ export function* b() {}
/* @__NO_SIDE_EFFECTS__ */ export async function c() {}
/* @__NO_SIDE_EFFECTS__ */ export async function* d() {}
export default /* @__NO_SIDE_EFFECTS__ */ async function() {}
export default /* @__NO_SIDE_EFFECTS__ */ function() {}
",
// Only "c0" and "c2" should have "no side effects" (Rollup only respects "const" and only for the first one)
r"
Expand Down
6 changes: 6 additions & 0 deletions crates/oxc_codegen/tests/integration/snapshots/pure_comments.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ export async function* d() {}
/* @__NO_SIDE_EFFECTS__ */ export function* b() {}
/* @__NO_SIDE_EFFECTS__ */ export async function c() {}
/* @__NO_SIDE_EFFECTS__ */ export async function* d() {}
export default /* @__NO_SIDE_EFFECTS__ */ async function() {}
export default /* @__NO_SIDE_EFFECTS__ */ function() {}

----------
/* @__NO_SIDE_EFFECTS__ */
Expand All @@ -138,6 +140,10 @@ export function* b() {}
export async function c() {}
/* @__NO_SIDE_EFFECTS__ */
export async function* d() {}
/* @__NO_SIDE_EFFECTS__ */
export default async function() {}
/* @__NO_SIDE_EFFECTS__ */
export default function() {}

########## 7

Expand Down
12 changes: 9 additions & 3 deletions crates/oxc_parser/src/js/module.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,8 @@ impl<'a> ParserImpl<'a> {
) -> Result<Box<'a, ExportDefaultDeclaration<'a>>> {
let exported = self.parse_keyword_identifier(Kind::Default);
let decl_span = self.start_span();
let has_no_side_effects_comment =
self.lexer.trivia_builder.previous_token_has_no_side_effects_comment();
// For tc39/proposal-decorators
// For more information, please refer to <https://babeljs.io/docs/babel-plugin-proposal-decorators#decoratorsbeforeexport>
self.eat_decorators()?;
Expand All @@ -406,9 +408,13 @@ impl<'a> ParserImpl<'a> {
}
})?
}
_ if self.at_function_with_async() => self
.parse_function_impl(FunctionKind::DefaultExport)
.map(ExportDefaultDeclarationKind::FunctionDeclaration)?,
_ if self.at_function_with_async() => {
let mut func = self.parse_function_impl(FunctionKind::DefaultExport)?;
if has_no_side_effects_comment {
func.pure = true;
}
ExportDefaultDeclarationKind::FunctionDeclaration(func)
}
_ => {
let decl = self
.parse_assignment_expression_or_higher()
Expand Down
Loading