Skip to content

test(ecmascript): add comments and tests for cases where ToPropertyKey throws an error #9429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 28, 2025
Merged

test(ecmascript): add comments and tests for cases where ToPropertyKey throws an error #9429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/oxc_ecmascript/src/side_effects/may_have_side_effects.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,8 @@ impl MayHaveSideEffects for PropertyKey<'_> {
match self {
PropertyKey::StaticIdentifier(_) | PropertyKey::PrivateIdentifier(_) => false,
match_expression!(PropertyKey) => {
// ToPropertyKey(key) throws an error when ToPrimitive(key) throws an Error
// But we can ignore that by using the assumption.
self.to_expression().may_have_side_effects(is_global_reference)
}
}
Expand Down
5 changes: 5 additions & 0 deletions crates/oxc_minifier/tests/ecmascript/may_have_side_effects.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,11 @@ fn test_object_expression() {
test("({[1]: 1})", false);
test("({[1n]: 1})", false);
test("({['1']: 1})", false);
// These actually have a side effect, but this treated as side-effect free.
test("({[{ toString() { console.log('sideeffect') } }]: 1})", false);
test("({[{ valueOf() { console.log('sideeffect') } }]: 1})", false);
test("({[{ [s]() { console.log('sideeffect') } }]: 1})", false); // assuming s is Symbol.toPrimitive
test("({[foo]: 1})", false);
test("({[foo()]: 1 })", true);
test("({a: foo()})", true);
test("({...a})", true);
Expand Down
Loading