Skip to content

ci(estree): ESTree conformance tester do not generate diff files in CI#9387

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-26-ci_estree_estree_conformance_tester_do_not_generate_diff_files_in_ci
Feb 26, 2025
Merged

ci(estree): ESTree conformance tester do not generate diff files in CI#9387
graphite-app[bot] merged 1 commit intomainfrom
02-26-ci_estree_estree_conformance_tester_do_not_generate_diff_files_in_ci

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 26, 2025

ESTree conformance tester generates diff files for mismatches. This is useful for local development, but it's quite slow, and is useless in CI. So skip generating diffs when running conformance in CI.

Copy link
Member Author

overlookmotel commented Feb 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 26, 2025 12:19
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 26, 2025
Copy link
Member

Boshen commented Feb 26, 2025

Merge activity

  • Feb 26, 8:07 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 26, 8:07 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 26, 8:13 AM EST: A user merged this pull request with the Graphite merge queue.

#9387)

ESTree conformance tester generates diff files for mismatches. This is useful for local development, but it's quite slow, and is useless in CI. So skip generating diffs when running conformance in CI.
@graphite-app graphite-app bot force-pushed the 02-23-test_napi_add_tests_for_hashbang_field branch from ee0f312 to 48d51e3 Compare February 26, 2025 13:08
@graphite-app graphite-app bot force-pushed the 02-26-ci_estree_estree_conformance_tester_do_not_generate_diff_files_in_ci branch from 14f96e5 to 5777281 Compare February 26, 2025 13:08
Base automatically changed from 02-23-test_napi_add_tests_for_hashbang_field to main February 26, 2025 13:13
@graphite-app graphite-app bot merged commit 5777281 into main Feb 26, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-26-ci_estree_estree_conformance_tester_do_not_generate_diff_files_in_ci branch February 26, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants