Skip to content

refactor(linter): allow indirect eval by default for eslint/no-eval#9302

Merged
camchenry merged 1 commit intooxc-project:mainfrom
shulaoda:refactor/no-eval-default
Feb 23, 2025
Merged

refactor(linter): allow indirect eval by default for eslint/no-eval#9302
camchenry merged 1 commit intooxc-project:mainfrom
shulaoda:refactor/no-eval-default

Conversation

@shulaoda
Copy link
Contributor

Related to #9300

The behavior is inconsistent with eslint, we default to allowing indirect eval.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@shulaoda shulaoda requested a review from Boshen February 23, 2025 15:17
@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 23, 2025
@shulaoda shulaoda marked this pull request as draft February 23, 2025 15:18
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 23, 2025

CodSpeed Performance Report

Merging #9302 will not alter performance

Comparing shulaoda:refactor/no-eval-default (d095f31) with main (3031845)

Summary

✅ 33 untouched benchmarks

@shulaoda shulaoda force-pushed the refactor/no-eval-default branch from 58ca4e5 to 32405c0 Compare February 23, 2025 15:26
@shulaoda shulaoda marked this pull request as ready for review February 23, 2025 15:26
@shulaoda shulaoda force-pushed the refactor/no-eval-default branch from f0180c3 to 796ce40 Compare February 23, 2025 15:28
@shulaoda shulaoda force-pushed the refactor/no-eval-default branch from 796ce40 to d095f31 Compare February 23, 2025 15:34
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Feb 23, 2025
Copy link
Member

camchenry commented Feb 23, 2025

Merge activity

  • Feb 23, 12:06 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 23, 12:06 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 23, 12:06 PM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 23, 2025
@camchenry camchenry merged commit fb7df52 into oxc-project:main Feb 23, 2025
26 checks passed
@shulaoda shulaoda deleted the refactor/no-eval-default branch February 23, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants