Skip to content

refactor(mangler): use iter::repeat_n#9272

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-21-refactor_mangler_use_iter_repeat_n_
Feb 21, 2025
Merged

refactor(mangler): use iter::repeat_n#9272
graphite-app[bot] merged 1 commit intomainfrom
02-21-refactor_mangler_use_iter_repeat_n_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 21, 2025

#9270 bumped MSRV to 1.82.0. So we can now use iter::repeat_n, which is slightly more performant than iter::repeat(...).take(...).

This reverts part of #8929, which removed APIs incompatible with 1.81.0.

Copy link
Member Author

overlookmotel commented Feb 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 21, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 21, 2025 14:46
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #9272 will not alter performance

Comparing 02-21-refactor_mangler_use_iter_repeat_n_ (3f0b5b3) with main (2726e29)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 21, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 21, 2025

Merge activity

#9270 bumped MSRV to 1.82.0. So we can now use `iter::repeat_n`, which is slightly more performant than `iter::repeat(...).take(...)`.

This reverts part of #8929, which removed APIs incompatible with 1.81.0.
@graphite-app graphite-app bot force-pushed the 02-21-refactor_mangler_use_iter_repeat_n_ branch from ce64c11 to 3f0b5b3 Compare February 21, 2025 15:01
@graphite-app graphite-app bot merged commit 3f0b5b3 into main Feb 21, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-21-refactor_mangler_use_iter_repeat_n_ branch February 21, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant