fix(wasm): transfer AST to JS as JSON string#9259
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 20, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
02-20-fix_wasm_transfer_ast_to_js_as_json_string
branch
from
047383b to
f41affb
Compare
Contributor
Merge activity
|
overlookmotel
force-pushed
the
02-20-fix_wasm_transfer_ast_to_js_as_json_string
branch
from
f41affb to
a670475
Compare
In [@oxc-parser/wasm](https://www.npmjs.com/package/@oxc-parser/wasm) NPM package, transfer the AST to JS as a JSON string, and parse it to a `Program` object on JS side. This fixes a couple of bugs - previously `RegExp`s and `BigInt`s were deserialized as `null`. The mechanism for doing this is pretty hacky. After `wasm-pack` generates the JS binding files, a script modifies these files to add a getter for `program` property on `ParseResult`. That getter deserializes the JSON to a `Program`. The hackyness is not ideal, but I'm not familiar enough with WASM build systems to see if there's a better way. This does at least seem to work!
graphite-app
bot
force-pushed
the
02-20-fix_wasm_transfer_ast_to_js_as_json_string
branch
from
a670475 to
5acc6ec
Compare
graphite-app
bot
deleted the
02-20-fix_wasm_transfer_ast_to_js_as_json_string
branch
This was referenced Feb 20, 2025
Boshen
pushed a commit
that referenced
this pull request
Feb 21, 2025
Same as #9259, but for `oxc-wasm` package. This fixes a couple of bugs - previously `RegExp`s and `BigInt`s were deserialized as `null`. Only differences from the implementation in [@oxc-parser/wasm](https://www.npmjs.com/package/@oxc-parser/wasm) are: 1. Getter for `ast` does not cache the result of `JSON.parse`. I couldn't quite get my head around Playground code, but I *think* the `Oxc` class instance is being used as a singleton, and therefore the value may change as the user updates the source code. 2. JSON is pretty-printed. This is so that when "Raw" is ticked, the JSON can be displayed exactly as it came out of the parser (rather than stringifying the AST object again).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In @oxc-parser/wasm NPM package, transfer the AST to JS as a JSON string, and parse it to a
Programobject on JS side.This fixes a couple of bugs - previously
RegExps andBigInts were deserialized asnull.The mechanism for doing this is pretty hacky. After
wasm-packgenerates the JS binding files, a script modifies these files to add a getter forprogramproperty onParseResult. That getter deserializes the JSON to aProgram.The hackyness is not ideal, but I'm not familiar enough with WASM build systems to see if there's a better way. This does at least seem to work!