Skip to content

refactor(ast/estree): simplify serializer for BindingProperty#9255

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-20-refactor_ast_estree_simplify_serializer_for_bindingproperty_
Feb 20, 2025
Merged

refactor(ast/estree): simplify serializer for BindingProperty#9255
graphite-app[bot] merged 1 commit intomainfrom
02-20-refactor_ast_estree_simplify_serializer_for_bindingproperty_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 20, 2025

Pure refactor. Simplify the impl Serialize for BindingProperty a bit.

Copy link
Member Author

overlookmotel commented Feb 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 20, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 20, 2025 02:17
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 20, 2025
Copy link
Member

Boshen commented Feb 20, 2025

Merge activity

  • Feb 19, 9:19 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 19, 9:40 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen changed the base branch from 02-20-refactor_allocator_linter_shorten_serde_impls to graphite-base/9255 February 20, 2025 02:19
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9255 will not alter performance

Comparing 02-20-refactor_ast_estree_simplify_serializer_for_bindingproperty_ (46b9151) with main (e32d6e2)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from graphite-base/9255 to main February 20, 2025 02:33
Pure refactor. Simplify the `impl Serialize` for `BindingProperty` a bit.
@graphite-app graphite-app bot force-pushed the 02-20-refactor_ast_estree_simplify_serializer_for_bindingproperty_ branch from f81c8b3 to 46b9151 Compare February 20, 2025 02:34
@graphite-app graphite-app bot merged commit 46b9151 into main Feb 20, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-20-refactor_ast_estree_simplify_serializer_for_bindingproperty_ branch February 20, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants