Skip to content

fix(ast/estree): remove unused TS type def for WithClause#9250

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-19-fix_ast_estree_remove_unused_ts_type_def_for_withclause_
Feb 19, 2025
Merged

fix(ast/estree): remove unused TS type def for WithClause#9250
graphite-app[bot] merged 1 commit intomainfrom
02-19-fix_ast_estree_remove_unused_ts_type_def_for_withclause_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 19, 2025

WithClause is flattened to just its with_entries field in ESTree AST, so the WithClause type doesn't appear in the ESTree AST. Remove the TS type def for it.

Copy link
Member Author

overlookmotel commented Feb 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Feb 19, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 19, 2025 21:25
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #9250 will not alter performance

Comparing 02-19-fix_ast_estree_remove_unused_ts_type_def_for_withclause_ (72bab88) with main (8a0d1a5)

Summary

✅ 33 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 19, 2025

Merge activity

`WithClause` is flattened to just its `with_entries` field in ESTree AST, so the `WithClause` type doesn't appear in the ESTree AST. Remove the TS type def for it.
@graphite-app graphite-app bot force-pushed the 02-19-fix_ast_estree_remove_unused_ts_type_def_for_withclause_ branch from a7d860f to 72bab88 Compare February 19, 2025 22:31
@graphite-app graphite-app bot merged commit 72bab88 into main Feb 19, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-19-fix_ast_estree_remove_unused_ts_type_def_for_withclause_ branch February 19, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant