refactor(span): manually derive Deserialize for CompactStr#9249
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 20, 2025
Merged
Conversation
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9249 will not alter performanceComparing Summary
|
Member
Merge activity
|
The `Deserialize` impl for `CompactStr` is trivial, so write it manually, rather than using `serde`'s heavy proc macro machinery. This allows disabling the `derive` feature for `serde` in `oxc_span` crate. Many other crates depend on `oxc_span`, so this chips away at compile times.
graphite-app
bot
force-pushed
the
02-19-refactor_span_manually_derive_deserialize_for_compactstr_
branch
from
d359f13 to
007c857
Compare
graphite-app
bot
deleted the
02-19-refactor_span_manually_derive_deserialize_for_compactstr_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Deserializeimpl forCompactStris trivial, so write it manually, rather than usingserde's heavy proc macro machinery.This allows disabling the
derivefeature forserdeinoxc_spancrate. Many other crates depend onoxc_span, so this chips away at compile times.