Skip to content

docs(ast): correct and improve docs for get_identifier methods on JSX types#9225

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-19-docs_ast_correct_and_improve_docs_for_get_identifier_methods_on_jsx_types
Feb 19, 2025
Merged

docs(ast): correct and improve docs for get_identifier methods on JSX types#9225
graphite-app[bot] merged 1 commit intomainfrom
02-19-docs_ast_correct_and_improve_docs_for_get_identifier_methods_on_jsx_types

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 19, 2025

Some doc comments for these methods were inaccurate, some were unclear. Improve them.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation labels Feb 19, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 19, 2025 12:01
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #9225 will not alter performance

Comparing 02-19-docs_ast_correct_and_improve_docs_for_get_identifier_methods_on_jsx_types (d4d01c3) with main (25c4d69)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 19, 2025
Copy link
Member

Boshen commented Feb 19, 2025

Merge activity

  • Feb 19, 8:22 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 19, 8:22 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 19, 8:29 AM EST: A user merged this pull request with the Graphite merge queue.

…SX types (#9225)

Some doc comments for these methods were inaccurate, some were unclear. Improve them.
@graphite-app graphite-app bot force-pushed the 02-19-docs_ast_correct_and_improve_docs_for_get_identifier_methods_on_jsx_types branch from bf3808f to d4d01c3 Compare February 19, 2025 13:23
@graphite-app graphite-app bot merged commit d4d01c3 into main Feb 19, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-19-docs_ast_correct_and_improve_docs_for_get_identifier_methods_on_jsx_types branch February 19, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants