Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
f982ff5 to
3dbcba2
Compare
3dbcba2 to
4e83d86
Compare
fd54a83 to
c956a60
Compare
overlookmotel
left a comment
There was a problem hiding this comment.
I'm not sure if we should do this.
Miri doesn't examine the whole crate, it just runs the tests and checks for any undefined behavior in those tests. What we're worried about (or at least I'm worried about) is the soundness of Traverse, but the tests in oxc_transformer crate are almost all unit tests which don't use Traverse, so they don't exercise the code paths that we want Miri to look at.
More testing is always better than less, but Miri is phenomenally slow to run. So I think we should only deploy Miri in quite a targeted way.
Let me think about this please...
c956a60 to
56e969f
Compare
4e83d86 to
611b029
Compare
56e969f to
d3142b2
Compare

No description provided.