Skip to content

ci(miri): add oxc_transformer to paths#9211

Closed
Dunqing wants to merge 1 commit intomainfrom
02-18-ci_miri_add_oxc_transformer_to_paths
Closed

ci(miri): add oxc_transformer to paths#9211
Dunqing wants to merge 1 commit intomainfrom
02-18-ci_miri_add_oxc_transformer_to_paths

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Feb 18, 2025

No description provided.

Copy link
Member Author

Dunqing commented Feb 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 02-18-feat_ast_remove_astbuilder_copy branch from f982ff5 to 3dbcba2 Compare February 18, 2025 20:15
@overlookmotel overlookmotel self-requested a review as a code owner February 18, 2025 20:15
@overlookmotel overlookmotel force-pushed the 02-18-feat_ast_remove_astbuilder_copy branch from 3dbcba2 to 4e83d86 Compare February 18, 2025 20:16
@overlookmotel overlookmotel force-pushed the 02-18-ci_miri_add_oxc_transformer_to_paths branch from fd54a83 to c956a60 Compare February 18, 2025 20:16
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should do this.

Miri doesn't examine the whole crate, it just runs the tests and checks for any undefined behavior in those tests. What we're worried about (or at least I'm worried about) is the soundness of Traverse, but the tests in oxc_transformer crate are almost all unit tests which don't use Traverse, so they don't exercise the code paths that we want Miri to look at.

More testing is always better than less, but Miri is phenomenally slow to run. So I think we should only deploy Miri in quite a targeted way.

Let me think about this please...

@overlookmotel overlookmotel changed the base branch from 02-18-feat_ast_remove_astbuilder_copy to graphite-base/9211 February 18, 2025 20:29
@overlookmotel overlookmotel force-pushed the 02-18-ci_miri_add_oxc_transformer_to_paths branch from c956a60 to 56e969f Compare February 18, 2025 20:34
@overlookmotel overlookmotel changed the base branch from graphite-base/9211 to main February 18, 2025 20:35
@overlookmotel overlookmotel force-pushed the 02-18-ci_miri_add_oxc_transformer_to_paths branch from 56e969f to d3142b2 Compare February 18, 2025 20:35
@overlookmotel overlookmotel marked this pull request as draft February 18, 2025 21:23
@Boshen Boshen closed this Feb 19, 2025
@Boshen Boshen deleted the 02-18-ci_miri_add_oxc_transformer_to_paths branch August 30, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants