feat(napi/transform): support enabling emitDecoratorMetadata#9190
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
emitDecoratorMetadata
c910956 to
e0d558a
Compare
overlookmotel
left a comment
There was a problem hiding this comment.
I've had a quick look through the PRs in this stack, but I'm not up to speed on how decorator metadata works, so I can't really review in full.
The only comment I have is the one I've made on #9189 (which I assume is nothing to worry about).
Do we maybe want to add 1 exec test (in a follow up) just to make sure it all works (including correctly interfacing with https://www.npmjs.com/package/reflect-metadata)?
But, that aside, if you're happy with it, please go ahead and merge.
e0d558a to
fbf1f31
Compare
086a176 to
2ad0f09
Compare
I've add an exec test in #9219 |
Merge activity
|
2ad0f09 to
6c24357
Compare
fbf1f31 to
8a5051e
Compare
… working with reflect-metadata well. (#9219) close: #9190 (review)

No description provided.