feat(linter): add eslint/max-lines-per-function#9161
Merged
Boshen merged 2 commits intooxc-project:mainfrom Feb 20, 2025
Merged
feat(linter): add eslint/max-lines-per-function#9161Boshen merged 2 commits intooxc-project:mainfrom
Boshen merged 2 commits intooxc-project:mainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
ikkz
force-pushed
the
feat/eslint-mlpf
branch
3 times, most recently
from
07c136a to
3a49a9d
Compare
CodSpeed Performance ReportMerging #9161 will not alter performanceComparing Summary
|
Contributor
Author
|
@shulaoda Thanks! I will optimize my subsequent PR according to this modification |
ikkz
commented
Feb 17, 2025
ikkz
changed the title
shulaoda
approved these changes
Feb 18, 2025
ikkz
force-pushed
the
feat/eslint-mlpf
branch
from
fed53c3 to
7b490ec
Compare
Boshen
requested changes
Feb 20, 2025
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
Sorry there's a small merge conflict.
ikkz
force-pushed
the
feat/eslint-mlpf
branch
from
7b490ec to
25f0445
Compare
Contributor
Author
|
@Boshen Fixed |
Boshen
approved these changes
Feb 20, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #479
Rule detail: https://eslint.org/docs/latest/rules/max-lines-per-function