Skip to content

feat(linter): add eslint/no-unneeded-ternary rule#9160

Merged
camchenry merged 5 commits intooxc-project:mainfrom
cdrikd:feature/eslint/no_unneeded_ternary
Feb 17, 2025
Merged

feat(linter): add eslint/no-unneeded-ternary rule#9160
camchenry merged 5 commits intooxc-project:mainfrom
cdrikd:feature/eslint/no_unneeded_ternary

Conversation

@cdrikd
Copy link
Contributor

@cdrikd cdrikd commented Feb 16, 2025

Implement the eslint/no-unneeded-ternary rule.

I have a question, where to put the options of the rules ? in the examples or in a specific chapter "Rule options" before examples ?

It's my first rust contribution, I just start to learn the language so don't hesitate to tell me enhancement.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 16, 2025
@camchenry camchenry self-requested a review February 17, 2025 02:49
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2025

CodSpeed Performance Report

Merging #9160 will not alter performance

Comparing cdrikd:feature/eslint/no_unneeded_ternary (571e653) with main (5681e41)

Summary

✅ 33 untouched benchmarks

cdrikd and others added 4 commits February 17, 2025 08:33
Co-authored-by: Cam McHenry <camchenry@users.noreply.github.com>
Co-authored-by: Cam McHenry <camchenry@users.noreply.github.com>
@cdrikd cdrikd requested a review from camchenry February 17, 2025 10:04
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Feb 17, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 17, 2025

Merge activity

  • Feb 17, 7:47 PM UTC: @cdrikd we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 17, 2025
@camchenry camchenry merged commit d70bad3 into oxc-project:main Feb 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants