Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #9154 will not alter performanceComparing Summary
|
sapphi-red
left a comment
There was a problem hiding this comment.
Yeah, this is safe. I didn't do it this way initially because it was a bit difficult to verify if it's safe.
Co-authored-by: 翠 / green <green@sapphi.red>
|
This will change the order of side effects. Math.pow({
valueOf() {
console.log("effect 1");
return 1;
}
}, {
valueOf() {
console.log("effect 2");
return 1;
}
},) |
|
@magic-akari Like other minifiers, OXC minifier assumes |
It's currently minifying twice through:
Math.pow(a, b)->(+a) ** (+b)->a ** (+b)Correct me if this is wrong, i.e. we need to keep
(+a)in the fold pass.