Skip to content

fix(isolated-declarations): private accessors keep their types#9132

Merged
Dunqing merged 1 commit intooxc-project:mainfrom
CPunisher:02-14-fix/isolated-private-auto-accessor
Feb 16, 2025
Merged

fix(isolated-declarations): private accessors keep their types#9132
Dunqing merged 1 commit intooxc-project:mainfrom
CPunisher:02-14-fix/isolated-private-auto-accessor

Conversation

@CPunisher
Copy link
Contributor

Input:

export class Cls {
  accessor d: string;
  private accessor e: string;
  private static accessor f: string;
}

Expected:

export declare class Cls {
    accessor d: string;
    private accessor e;
    private static accessor f;
}

Actual:

export declare class Cls {
    accessor d: string;
    private accessor e: string;
    private static accessor f: string;
}

ts playground: https://www.typescriptlang.org/play/?#code/MYGwhgzhAEDCIwN4ChrTMYBTKB7ATtACYBc0EALvgJYB2A5gNyrQAONAbmBVupjhALQsZSjQbM07alx7kK3asD7Y8hAGaiqdJsgC+yZEA

@CPunisher CPunisher requested a review from Dunqing as a code owner February 15, 2025 04:17
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-isolated-declarations Isolated Declarations C-bug Category - Bug labels Feb 15, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2025

CodSpeed Performance Report

Merging #9132 will not alter performance

Comparing CPunisher:02-14-fix/isolated-private-auto-accessor (b2194e0) with main (0715e34)

Summary

✅ 33 untouched benchmarks

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dunqing Dunqing merged commit 9e3571f into oxc-project:main Feb 16, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-isolated-declarations Isolated Declarations C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants