Skip to content

feat(linter): implement grouped-accessor-pairs#9065

Merged
Sysix merged 8 commits intooxc-project:mainfrom
huangtiandi1999:feat/linter/grouped-accessor-pairs
Feb 18, 2025
Merged

feat(linter): implement grouped-accessor-pairs#9065
Sysix merged 8 commits intooxc-project:mainfrom
huangtiandi1999:feat/linter/grouped-accessor-pairs

Conversation

@huangtiandi1999
Copy link
Contributor

This feature is primarily used to implement eslint grouped-accessor-pairs rule, all the test cases passed, and I still need to make some adjustments to the code implementation, Once that's done, I'll request a review 😊

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 12, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@huangtiandi1999 huangtiandi1999 marked this pull request as draft February 12, 2025 11:42
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 12, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #9065 will not alter performance

Comparing huangtiandi1999:feat/linter/grouped-accessor-pairs (f7bee3d) with main (e8fa091)

Summary

✅ 33 untouched benchmarks

@huangtiandi1999 huangtiandi1999 marked this pull request as ready for review February 17, 2025 09:29
@huangtiandi1999
Copy link
Contributor Author

@camchenry @Sysix Hi guys this PR is ready, please help review it 😊

@Sysix
Copy link
Member

Sysix commented Feb 18, 2025

thanks you ❤️

@Sysix Sysix merged commit 86795d0 into oxc-project:main Feb 18, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants