test(napi): add NAPI parser benchmark#9045
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 11, 2025
Merged
Conversation
github-actions
bot
added
the
C-test
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
changed the base branch from
02-11-fix_ast_estree_fix_serializing_regexpliteral_
to
graphite-base/9045
Member
Author
|
Can't see any downside to adding this, so merging without review. |
Member
Author
Merge activity
|
Add a quick benchmark for NAPI parser. It's included in our CI benchmarks, because likely will produce too much variance, but it's useful for local runs.
graphite-app
bot
force-pushed
the
02-11-test_napi_add_napi_parser_benchmark
branch
from
165d78b to
ef553b9
Compare
graphite-app
bot
deleted the
02-11-test_napi_add_napi_parser_benchmark
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
…s on JS side (#9044) Add a "reviver" function to `JSON.parse` in NAPI parser module, to correctly set `value` field of `Literal`s for `RegExp`s and `BigInt`s. Surprisingly, judging by a local run of NAPI parser benchmarks (added in #9045), this does not seem to hurt performance. In fact the benchmarks were showing a ~2% speed-up. That's clearly nonsense - just noise - but it does suggest at least that this isn't hurting performance significantly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a quick benchmark for NAPI parser. It's included in our CI benchmarks, because likely will produce too much variance, but it's useful for local runs.