Skip to content

refactor(ast/estree): remove redundant ts_type#9037

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-11-refactor_ast_estree_remove_redundant_ts_type_
Feb 11, 2025
Merged

refactor(ast/estree): remove redundant ts_type#9037
graphite-app[bot] merged 1 commit intomainfrom
02-11-refactor_ast_estree_remove_redundant_ts_type_

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 11, 2025

We hard-coded BindingPattern for this, so it's now redundant.

// need `type` instead of `interface` when flattening BindingPattern
if field_type_name.contains('|') || field_type_name == "BindingPattern" {
*output_as_type = true;
}

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 11, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hi-ogawa hi-ogawa marked this pull request as ready for review February 11, 2025 07:09
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #9037 will not alter performance

Comparing 02-11-refactor_ast_estree_remove_redundant_ts_type_ (cb3240c) with main (f705c64)

Summary

✅ 33 untouched benchmarks

@hi-ogawa hi-ogawa added the 0-merge Merge with Graphite Merge Queue label Feb 11, 2025
Copy link
Contributor Author

hi-ogawa commented Feb 11, 2025

Merge activity

  • Feb 11, 2:12 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 11, 2:12 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 11, 2:17 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 02-11-refactor_ast_estree_remove_redundant_ts_type_ branch from 4748dd0 to cb3240c Compare February 11, 2025 07:12
@graphite-app graphite-app bot merged commit cb3240c into main Feb 11, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-11-refactor_ast_estree_remove_redundant_ts_type_ branch February 11, 2025 07:17
@overlookmotel
Copy link
Member

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants