fix(ast/estree): serialize PrivateInExpression as BinaryExpression#9033
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 11, 2025
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
Merge activity
|
graphite-app
bot
force-pushed
the
02-11-fix_ast_estree_fix_exportalldeclaration_attributes
branch
from
5932b2f to
2948804
Compare
CodSpeed Performance ReportMerging #9033 will not alter performanceComparing Summary
|
graphite-app
bot
force-pushed
the
02-11-fix_ast_estree_serialize_privateinexpression_as_binaryexpression_
branch
from
e53caea to
f705c64
Compare
Base automatically changed from
02-11-fix_ast_estree_fix_exportalldeclaration_attributes
to
main
February 11, 2025 05:04
graphite-app
bot
deleted the
02-11-fix_ast_estree_serialize_privateinexpression_as_binaryexpression_
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
Remove `PrivateInExpression::operator` field. This field had no purpose beyond getting correct serialization to ESTree - it was always `BinaryOperator::In`, and no other value for `operator` makes sense in this position. So remove the field from the Rust type, and produce the desired output in ESTree AST using `#[estree(add_fields)]` instead. This follows on after changes made to serialization of `PrivateInExpression` in #9033.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.