fix(ast): estree compat AssignmentTargetPropertyProperty#9005
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2025
Merged
fix(ast): estree compat AssignmentTargetPropertyProperty#9005graphite-app[bot] merged 1 commit intomainfrom
AssignmentTargetPropertyProperty#9005graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-ast
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9005 will not alter performanceComparing Summary
|
hi-ogawa
changed the base branch from
fix-estree-AssignmentTargetPattern
to
graphite-base/9005
hi-ogawa
force-pushed
the
graphite-base/9005
branch
from
c9d15f7 to
c656783
Compare
hi-ogawa
force-pushed
the
fix-estree-ObjectAssignmentTarget
branch
from
a134ef9 to
6128a6b
Compare
hi-ogawa
changed the title
AssignmentTargetPropertyPropertyAssignmentTargetProperty
hi-ogawa
changed the title
AssignmentTargetPropertyObjectAssignmentTarget
hi-ogawa
changed the title
ObjectAssignmentTargetAssignmentTargetPropertyProperty
overlookmotel
force-pushed
the
graphite-base/9005
branch
from
c656783 to
e0646d7
Compare
overlookmotel
force-pushed
the
fix-estree-ObjectAssignmentTarget
branch
from
6d7c3c7 to
b69fb5f
Compare
overlookmotel
approved these changes
Feb 10, 2025
Member
Merge activity
|
graphite-app
bot
force-pushed
the
fix-estree-ObjectAssignmentTarget
branch
from
b69fb5f to
1daa8fe
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
This one seemed less straight forward than `AssignmentTargetPropertyProperty`, so I split it from #9005. This requires somewhat redundant custom serialization logic, but this is all I came up with. I'm curious to know if there's any good shortcut for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.