Skip to content

refactor(minifier): extract symbols().symbol_is_used(symbol_id) #8995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 10, 2025
Merged

refactor(minifier): extract symbols().symbol_is_used(symbol_id) #8995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,7 +1076,7 @@ impl<'a> LatePeepholeOptimizations {
if let Some(param) = &catch.param {
if let BindingPatternKind::BindingIdentifier(ident) = &param.pattern.kind {
if catch.body.body.is_empty()
|| ctx.symbols().get_resolved_references(ident.symbol_id()).count() == 0
|| !ctx.symbols().symbol_is_used(ident.symbol_id())
{
catch.param = None;
}
Expand Down
5 changes: 5 additions & 0 deletions crates/oxc_semantic/src/symbol.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ impl SymbolTable {
}
}

/// Get whether a symbol is used (i.e. read or written after declaration).
pub fn symbol_is_used(&self, symbol_id: SymbolId) -> bool {
self.get_resolved_references(symbol_id).count() > 0
}

/// Add a reference to a symbol.
pub fn add_resolved_reference(&mut self, symbol_id: SymbolId, reference_id: ReferenceId) {
self.inner.with_dependent_mut(|_allocator, inner| {
Expand Down
Loading