fix(ecmascript): fix may_have_side_effects for binary expressions#8991
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2025
Conversation
Member
Author
This was referenced Feb 10, 2025
Merged
CodSpeed Performance ReportMerging #8991 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
4aca101 to
2a10a99
Compare
706bacd to
9a5a926
Compare
Base automatically changed from
02-08-feat_ecmascript_support_arrays_and_objects_for_unary_expression_may_have_side_effects
to
main
February 10, 2025 05:49
This was referenced Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes the FIXME test cases related to binary expressions in may_have_side_effects.