Skip to content

fix(ecmascript): fix may_have_side_effects for binary expressions#8991

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-08-fix_ecmascript_fix_may_have_side_effects_for_binary_expressions
Feb 10, 2025
Merged

fix(ecmascript): fix may_have_side_effects for binary expressions#8991
graphite-app[bot] merged 1 commit intomainfrom
02-08-fix_ecmascript_fix_may_have_side_effects_for_binary_expressions

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 10, 2025

Fixes the FIXME test cases related to binary expressions in may_have_side_effects.

Copy link
Member Author

sapphi-red commented Feb 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #8991 will not alter performance

Comparing 02-08-fix_ecmascript_fix_may_have_side_effects_for_binary_expressions (9a5a926) with main (addaa8e)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 10, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 10, 2025

Merge activity

)

Fixes the FIXME test cases related to binary expressions in may_have_side_effects.
@graphite-app graphite-app bot force-pushed the 02-08-feat_ecmascript_support_arrays_and_objects_for_unary_expression_may_have_side_effects branch from 4aca101 to 2a10a99 Compare February 10, 2025 05:36
@graphite-app graphite-app bot force-pushed the 02-08-fix_ecmascript_fix_may_have_side_effects_for_binary_expressions branch from 706bacd to 9a5a926 Compare February 10, 2025 05:37
Base automatically changed from 02-08-feat_ecmascript_support_arrays_and_objects_for_unary_expression_may_have_side_effects to main February 10, 2025 05:49
@graphite-app graphite-app bot merged commit 9a5a926 into main Feb 10, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 02-08-fix_ecmascript_fix_may_have_side_effects_for_binary_expressions branch February 10, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant