Skip to content

feat(linter): add vitest/no-standalone-expect rule #8986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sysix merged 4 commits into from
Feb 10, 2025
Merged

feat(linter): add vitest/no-standalone-expect rule #8986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e3351b
add vitest/no-standalone-expect
taearls Jan 31, 2025
3393de1
Merge branch 'main' into linter/vitest-no-standalone-expect
taearls Feb 1, 2025
1b27f0a
add some documentation
taearls Feb 1, 2025
a9eea7e
move no_standalone_expect rule to dir and migrate existing logic and …
taearls Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 0 additions & 160 deletions ...er/src/rules/jest/no_standalone_expect.rs → ...rc/rules/jest/no_standalone_expect/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,163 +231,3 @@ fn is_var_declarator_or_test_block<'a>(

false
}

#[test]
fn test() {
use crate::tester::Tester;

let pass = vec![
("expect.any(String)", None),
("expect.extend({})", None),
("describe('a test', () => { it('an it', () => {expect(1).toBe(1); }); });", None),
(
"describe('a test', () => { it('an it', () => { const func = () => { expect(1).toBe(1); }; }); });",
None,
),
("describe('a test', () => { const func = () => { expect(1).toBe(1); }; });", None),
("describe('a test', () => { function func() { expect(1).toBe(1); }; });", None),
("describe('a test', () => { const func = function(){ expect(1).toBe(1); }; });", None),
("it('an it', () => expect(1).toBe(1))", None),
("const func = function(){ expect(1).toBe(1); };", None),
("const func = () => expect(1).toBe(1);", None),
("{}", None),
("it.each([1, true])('trues', value => { expect(value).toBe(true); });", None),
(
"it.each([1, true])('trues', value => { expect(value).toBe(true); }); it('an it', () => { expect(1).toBe(1) });",
None,
),
(
"
it.each`
num | value
${1} | ${true}
`('trues', ({ value }) => {
expect(value).toBe(true);
});
",
None,
),
("it.only('an only', value => { expect(value).toBe(true); });", None),
("it.concurrent('an concurrent', value => { expect(value).toBe(true); });", None),
(
"describe.each([1, true])('trues', value => { it('an it', () => expect(value).toBe(true) ); });",
None,
),
(
"
describe('scenario', () => {
const t = Math.random() ? it.only : it;
t('testing', () => expect(true));
});
",
Some(serde_json::json!([{ "additionalTestBlockFunctions": ['t'] }])),
),
(
r"
each([
[1, 1, 2],
[1, 2, 3],
[2, 1, 3],
]).test('returns the result of adding %d to %d', (a, b, expected) => {
expect(a + b).toBe(expected);
});
",
Some(serde_json::json!([{ "additionalTestBlockFunctions": ["each.test"] }])),
),
];

let fail = vec![
("(() => {})('testing', () => expect(true).toBe(false))", None),
("expect.hasAssertions()", None),
("expect().hasAssertions()", None),
(
"
describe('scenario', () => {
const t = Math.random() ? it.only : it;
t('testing', () => expect(true).toBe(false));
});
",
None,
),
(
"
describe('scenario', () => {
const t = Math.random() ? it.only : it;
t('testing', () => expect(true).toBe(false));
});
",
None,
),
(
"
each([
[1, 1, 2],
[1, 2, 3],
[2, 1, 3],
]).test('returns the result of adding %d to %d', (a, b, expected) => {
expect(a + b).toBe(expected);
});
",
None,
),
(
"
each([
[1, 1, 2],
[1, 2, 3],
[2, 1, 3],
]).test('returns the result of adding %d to %d', (a, b, expected) => {
expect(a + b).toBe(expected);
});
",
Some(serde_json::json!([{ "additionalTestBlockFunctions": ["each"] }])),
),
(
"
each([
[1, 1, 2],
[1, 2, 3],
[2, 1, 3],
]).test('returns the result of adding %d to %d', (a, b, expected) => {
expect(a + b).toBe(expected);
});
",
Some(serde_json::json!([{ "additionalTestBlockFunctions": ["test"] }])),
),
("describe('a test', () => { expect(1).toBe(1); });", None),
("describe('a test', () => expect(1).toBe(1));", None),
(
"describe('a test', () => { const func = () => { expect(1).toBe(1); }; expect(1).toBe(1); });",
None,
),
(
"describe('a test', () => { it(() => { expect(1).toBe(1); }); expect(1).toBe(1); });",
None,
),
("expect(1).toBe(1);", None),
("{expect(1).toBe(1)}", None),
(
"it.each([1, true])('trues', value => { expect(value).toBe(true); }); expect(1).toBe(1);",
None,
),
("describe.each([1, true])('trues', value => { expect(value).toBe(true); });", None),
(
"
import { expect as pleaseExpect } from '@jest/globals';
describe('a test', () => { pleaseExpect(1).toBe(1); });
",
None,
),
(
"
import { expect as pleaseExpect } from '@jest/globals';
beforeEach(() => pleaseExpect.hasAssertions());
",
None,
),
];

Tester::new(NoStandaloneExpect::NAME, NoStandaloneExpect::PLUGIN, pass, fail)
.with_jest_plugin(true)
.test_and_snapshot();
}
161 changes: 161 additions & 0 deletions crates/oxc_linter/src/rules/jest/no_standalone_expect/tests/jest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,161 @@
#[test]
fn test() {
use super::PreferLowercaseTitle;
use crate::rule::RuleMeta;
use crate::tester::Tester;

let pass = vec![
("expect.any(String)", None),
("expect.extend({})", None),
("describe('a test', () => { it('an it', () => {expect(1).toBe(1); }); });", None),
(
"describe('a test', () => { it('an it', () => { const func = () => { expect(1).toBe(1); }; }); });",
None,
),
("describe('a test', () => { const func = () => { expect(1).toBe(1); }; });", None),
("describe('a test', () => { function func() { expect(1).toBe(1); }; });", None),
("describe('a test', () => { const func = function(){ expect(1).toBe(1); }; });", None),
("it('an it', () => expect(1).toBe(1))", None),
("const func = function(){ expect(1).toBe(1); };", None),
("const func = () => expect(1).toBe(1);", None),
("{}", None),
("it.each([1, true])('trues', value => { expect(value).toBe(true); });", None),
(
"it.each([1, true])('trues', value => { expect(value).toBe(true); }); it('an it', () => { expect(1).toBe(1) });",
None,
),
(
"
it.each`
num | value
${1} | ${true}
`('trues', ({ value }) => {
expect(value).toBe(true);
});
",
None,
),
("it.only('an only', value => { expect(value).toBe(true); });", None),
("it.concurrent('an concurrent', value => { expect(value).toBe(true); });", None),
(
"describe.each([1, true])('trues', value => { it('an it', () => expect(value).toBe(true) ); });",
None,
),
(
"
describe('scenario', () => {
const t = Math.random() ? it.only : it;
t('testing', () => expect(true));
});
",
Some(serde_json::json!([{ "additionalTestBlockFunctions": ['t'] }])),
),
(
r"
each([
[1, 1, 2],
[1, 2, 3],
[2, 1, 3],
]).test('returns the result of adding %d to %d', (a, b, expected) => {
expect(a + b).toBe(expected);
});
",
Some(serde_json::json!([{ "additionalTestBlockFunctions": ["each.test"] }])),
),
];

let fail = vec![
("(() => {})('testing', () => expect(true).toBe(false))", None),
("expect.hasAssertions()", None),
("expect().hasAssertions()", None),
(
"
describe('scenario', () => {
const t = Math.random() ? it.only : it;
t('testing', () => expect(true).toBe(false));
});
",
None,
),
(
"
describe('scenario', () => {
const t = Math.random() ? it.only : it;
t('testing', () => expect(true).toBe(false));
});
",
None,
),
(
"
each([
[1, 1, 2],
[1, 2, 3],
[2, 1, 3],
]).test('returns the result of adding %d to %d', (a, b, expected) => {
expect(a + b).toBe(expected);
});
",
None,
),
(
"
each([
[1, 1, 2],
[1, 2, 3],
[2, 1, 3],
]).test('returns the result of adding %d to %d', (a, b, expected) => {
expect(a + b).toBe(expected);
});
",
Some(serde_json::json!([{ "additionalTestBlockFunctions": ["each"] }])),
),
(
"
each([
[1, 1, 2],
[1, 2, 3],
[2, 1, 3],
]).test('returns the result of adding %d to %d', (a, b, expected) => {
expect(a + b).toBe(expected);
});
",
Some(serde_json::json!([{ "additionalTestBlockFunctions": ["test"] }])),
),
("describe('a test', () => { expect(1).toBe(1); });", None),
("describe('a test', () => expect(1).toBe(1));", None),
(
"describe('a test', () => { const func = () => { expect(1).toBe(1); }; expect(1).toBe(1); });",
None,
),
(
"describe('a test', () => { it(() => { expect(1).toBe(1); }); expect(1).toBe(1); });",
None,
),
("expect(1).toBe(1);", None),
("{expect(1).toBe(1)}", None),
(
"it.each([1, true])('trues', value => { expect(value).toBe(true); }); expect(1).toBe(1);",
None,
),
("describe.each([1, true])('trues', value => { expect(value).toBe(true); });", None),
(
"
import { expect as pleaseExpect } from '@jest/globals';
describe('a test', () => { pleaseExpect(1).toBe(1); });
",
None,
),
(
"
import { expect as pleaseExpect } from '@jest/globals';
beforeEach(() => pleaseExpect.hasAssertions());
",
None,
),
];

Tester::new(NoStandaloneExpect::NAME, NoStandaloneExpect::PLUGIN, pass, fail)
.with_jest_plugin(true)
.test_and_snapshot();
}
4 changes: 4 additions & 0 deletions crates/oxc_linter/src/rules/jest/no_standalone_expect/tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
mod jest;
mod vitest;

use super::NoStandaloneExpect;
Loading