feat(napi/parser): add convert_span_utf16 option#8983
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 11, 2025
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
hi-ogawa
force-pushed
the
feat-napi-parser-utf16
branch
from
918100d to
a24cfab
Compare
Boshen
reviewed
Feb 11, 2025
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
Eventually this should be an estree option. With proper documentation regarding its performance characteristics.
At present we should document it as for internal use only.
hi-ogawa
force-pushed
the
feat-napi-parser-utf16
branch
2 times, most recently
from
a2fcb7c to
53fc349
Compare
Member
Merge activity
|
For starter, I added opt-in `convert_span_utf16` for `napi/parser` level option, so rolldown-vite can start to battle test estree output.
graphite-app
bot
force-pushed
the
feat-napi-parser-utf16
branch
from
53fc349 to
81c81a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For starter, I added opt-in
convert_span_utf16fornapi/parserlevel option, so rolldown-vite can start to battle test estree output.