docs(linter): add prettier-ignore where formatting ruins code#8978
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 8, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-docs
CodSpeed Performance ReportMerging #8978 will not alter performanceComparing Summary
|
Sysix
approved these changes
Feb 8, 2025
Member
Merge activity
|
While running `just website`, I noticed that these docs were causing some issues when running `npm run fmt` subsequently, I think due to the usage of character escapes. Disabling prettier seems to stop this from occurring. Also the code examples in `no-nonoctal-decimal-escape` had weird formatting due to the usage of text which gets parsed as a label, so I updated the example.
graphite-app
bot
force-pushed
the
02-07-docs_linter_add_prettier-ignore_where_formatting_ruins_code
branch
from
3f409ce to
02cb45b
Compare
graphite-app
bot
deleted the
02-07-docs_linter_add_prettier-ignore_where_formatting_ruins_code
branch
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
While running `just website`, I noticed that these docs were causing some issues when running `npm run fmt` subsequently, I think due to the usage of character escapes. Disabling prettier seems to stop this from occurring. Also the code examples in `no-nonoctal-decimal-escape` had weird formatting due to the usage of text which gets parsed as a label, so I updated the example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running
just website, I noticed that these docs were causing some issues when runningnpm run fmtsubsequently, I think due to the usage of character escapes. Disabling prettier seems to stop this from occurring.Also the code examples in
no-nonoctal-decimal-escapehad weird formatting due to the usage of text which gets parsed as a label, so I updated the example.