fix(ast): estree compat CatchClause

crates/oxc_ast/src/ast/js.rs

@@ -1401,6 +1401,7 @@ pub struct CatchClause<'a> {
 pub struct CatchParameter<'a> {
     pub span: Span,
     /// The bound error
+    #[estree(flatten)]
     pub pattern: BindingPattern<'a>,
 }
 

crates/oxc_ast/src/generated/derive_estree.rs

@@ -1222,7 +1222,9 @@ impl Serialize for CatchParameter<'_> {
         map.serialize_entry("type", "CatchParameter")?;
         map.serialize_entry("start", &self.span.start)?;
         map.serialize_entry("end", &self.span.end)?;
-        map.serialize_entry("pattern", &self.pattern)?;
+        self.pattern.kind.serialize(FlatMapSerializer(&mut map))?;
+        map.serialize_entry("typeAnnotation", &self.pattern.type_annotation)?;
+        map.serialize_entry("optional", &self.pattern.optional)?;
         map.end()
     }
 }

npm/oxc-types/types.d.ts

@@ -483,10 +483,12 @@ export interface CatchClause extends Span {
   body: BlockStatement;
 }
 
-export interface CatchParameter extends Span {
-  type: 'CatchParameter';
-  pattern: BindingPattern;
-}
+export type CatchParameter =
+  & ({
+    type: 'CatchParameter';
+  })
+  & Span
+  & BindingPattern;
 
 export interface DebuggerStatement extends Span {
   type: 'DebuggerStatement';

tasks/ast_tools/src/generators/typescript.rs

@@ -220,7 +220,8 @@ fn generate_ts_type_def_for_struct_field<'s>(
             }
         }
 
-        if field_type_name.contains('|') {
+        // need `type` instead of `interface` when flattening BindingPattern
+        if field_type_name.contains('|') || field_type_name == "BindingPattern" {
             *output_as_type = true;
         }
         extends.push(field_type_name);