Skip to content

fix(transformer/typescript): typescript parameter properties disappear when there's two or more classes that uses that feature#8969

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-07-fix_transformer_typescript_typescript_parameter_properties_disappear_when_there_s_two_or_more_classes_that_uses_that_feature
Feb 7, 2025
Merged

fix(transformer/typescript): typescript parameter properties disappear when there's two or more classes that uses that feature#8969
graphite-app[bot] merged 1 commit intomainfrom
02-07-fix_transformer_typescript_typescript_parameter_properties_disappear_when_there_s_two_or_more_classes_that_uses_that_feature

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Feb 7, 2025

close: #8917

This problem is due to forgetting to reset the status.

Copy link
Member Author

Dunqing commented Feb 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing force-pushed the 02-07-fix_transformer_typescript_typescript_parameter_properties_disappear_when_there_s_two_or_more_classes_that_uses_that_feature branch from 3282231 to 28696e9 Compare February 7, 2025 14:38
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Feb 7, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 7, 2025
Copy link
Member

overlookmotel commented Feb 7, 2025

Merge activity

  • Feb 7, 9:44 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 7, 9:46 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 7, 10:19 AM EST: A user merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 7, 2025

CodSpeed Performance Report

Merging #8969 will not alter performance

Comparing 02-07-fix_transformer_typescript_typescript_parameter_properties_disappear_when_there_s_two_or_more_classes_that_uses_that_feature (2c4f004) with main (a4a8e7d)

Summary

✅ 33 untouched benchmarks

…r when there's two or more classes that uses that feature (#8969)

close: #8917

This problem is due to forgetting to reset the status.
@graphite-app graphite-app bot force-pushed the 02-07-fix_transformer_typescript_typescript_parameter_properties_disappear_when_there_s_two_or_more_classes_that_uses_that_feature branch from 28696e9 to 2c4f004 Compare February 7, 2025 15:10
@graphite-app graphite-app bot merged commit 2c4f004 into main Feb 7, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 02-07-fix_transformer_typescript_typescript_parameter_properties_disappear_when_there_s_two_or_more_classes_that_uses_that_feature branch February 7, 2025 15:19
Dunqing added a commit that referenced this pull request Feb 10, 2025
…r when there's two or more classes that uses that feature (#8969)

close: #8917

This problem is due to forgetting to reset the status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformer: typescript parameter properties disappear when there's two or more classes that uses that feature

2 participants