Skip to content

fix(ecmascript): ValueType::from for unknown value should return Undetermined instead of Number #8954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 7, 2025
Merged

fix(ecmascript): ValueType::from for unknown value should return Undetermined instead of Number #8954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions crates/oxc_ecmascript/src/constant_evaluation/value_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,16 @@ impl<'a> From<&Expression<'a>> for ValueType {
UnaryOperator::Void => Self::Undefined,
UnaryOperator::UnaryNegation => {
let argument_ty = Self::from(&unary_expr.argument);
if argument_ty == Self::BigInt {
return Self::BigInt;
match argument_ty {
Self::BigInt => Self::BigInt,
// non-object values other than BigInt are converted to number by `ToNumber`
Self::Number
| Self::Boolean
| Self::String
| Self::Null
| Self::Undefined => Self::Number,
Self::Undetermined | Self::Object => Self::Undetermined,
}
Self::Number
}
UnaryOperator::UnaryPlus => Self::Number,
UnaryOperator::LogicalNot | UnaryOperator::Delete => Self::Boolean,
Expand Down
8 changes: 7 additions & 1 deletion crates/oxc_minifier/tests/ecmascript/value_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ fn unary_tests() {
test("-0", ValueType::Number);
test("-Infinity", ValueType::Number);
test("-0n", ValueType::BigInt);
// test("-foo", ValueType::Undetermined); // can be number or bigint
test("-true", ValueType::Number); // -1
test("-''", ValueType::Number); // -0
test("-'0n'", ValueType::Number); // NaN
test("-null", ValueType::Number); // -0
test("-undefined", ValueType::Number); // NaN
test("-{ valueOf() { return 0n } }", ValueType::Undetermined);
test("-foo", ValueType::Undetermined); // can be number or bigint

test("+0", ValueType::Number);
test("+true", ValueType::Number);
Expand Down
2 changes: 1 addition & 1 deletion tasks/minsize/minsize.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Original | minified | minified | gzip | gzip | Fixture

1.25 MB | 650.34 kB | 646.76 kB | 160.96 kB | 163.73 kB | three.js

2.14 MB | 717.04 kB | 724.14 kB | 162.02 kB | 181.07 kB | victory.js
2.14 MB | 717.05 kB | 724.14 kB | 162.02 kB | 181.07 kB | victory.js

3.20 MB | 1.01 MB | 1.01 MB | 324.34 kB | 331.56 kB | echarts.js

Expand Down
Loading