style(all): replace #[allow] with #[expect]#8930
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 7, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
requested review from
Boshen,
Dunqing and
leaysgur
as code owners
CodSpeed Performance ReportMerging #8930 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-06-style_all_replace_allow_with_expect_
branch
from
bda2807 to
cb3f74c
Compare
overlookmotel
force-pushed
the
02-06-style_all_replace_allow_with_expect_
branch
from
cb3f74c to
172916b
Compare
Contributor
Merge activity
|
Replace `#[allow]` with `#[expect]` through the whole codebase. This also surfaced many places where the `#[allow]` attributes were outdated/pointless and could be removed entirely. Only places `#[allow]` remains are: 1. In generated code and macros, where lint errors may or may not be triggered depending on the generated code. 2. A few places where clippy malfunctions. These use e.g. `#[allow(unused, clippy::allow_attributes)]`.
graphite-app
bot
force-pushed
the
02-06-style_all_replace_allow_with_expect_
branch
from
172916b to
a4a8e7d
Compare
graphite-app
bot
deleted the
02-06-style_all_replace_allow_with_expect_
branch
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
Replace `#[allow]` with `#[expect]` through the whole codebase. This also surfaced many places where the `#[allow]` attributes were outdated/pointless and could be removed entirely. Only places `#[allow]` remains are: 1. In generated code and macros, where lint errors may or may not be triggered depending on the generated code. 2. A few places where clippy malfunctions. These use e.g. `#[allow(unused, clippy::allow_attributes)]`.
This was referenced Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
#[allow]with#[expect]through the whole codebase.This also surfaced many places where the
#[allow]attributes were outdated/pointless and could be removed entirely.Only places
#[allow]remains are:#[allow(unused, clippy::allow_attributes)].