refactor(ast_tools): store lists as Vecs not Option<Vec>s#8925
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 6, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast-tools
Member
Author
|
cc @hi-ogawa |
Member
Author
|
Originally I used |
Contributor
Merge activity
|
In `Schema`, store lists of name-value pairs from attributes (e.g. `#[visit(args(x = 1, y = 2))]`, `#[estree(add_entry(x = 1, y = 2))]`) as `Vec`s, instead of `Option<Vec>`. This has 3 effects: 1. Attribute parsers can append to the `Vec`. So now these 2 syntaxes are both supported, and equivalent: ```rs #[estree(add_entry(x = 1, y = 2))] ``` ```rs #[estree(add_entry(x = 1))] #[estree(add_entry(y = 2))] ``` 2. Make multiple items in `#[estree(add_entry(...))]` supported. Previously all except the first were ignored. 3. Shorten code in generators.
graphite-app
bot
force-pushed
the
02-06-refactor_ast_tools_add_helper_methods_to_attrpartlistelement_
branch
from
e17ed16 to
cc8a311
Compare
graphite-app
bot
force-pushed
the
02-06-refactor_ast_tools_store_lists_as_vec_s_not_option_vec_s
branch
from
f4b2acd to
ab601a1
Compare
Base automatically changed from
02-06-refactor_ast_tools_add_helper_methods_to_attrpartlistelement_
to
main
February 6, 2025 15:24
graphite-app
bot
deleted the
02-06-refactor_ast_tools_store_lists_as_vec_s_not_option_vec_s
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Schema, store lists of name-value pairs from attributes (e.g.#[visit(args(x = 1, y = 2))],#[estree(add_entry(x = 1, y = 2))]) asVecs, instead ofOption<Vec>.This has 3 effects:
Vec. So now these 2 syntaxes are both supported, and equivalent:#[estree(add_entry(x = 1, y = 2))]Make multiple items in
#[estree(add_entry(...))]supported. Previously all except the first were ignored.Shorten code in generators.