fix(ast): estree compat MemberExpression#8921
Merged
overlookmotel merged 12 commits intooxc-project:mainfrom Feb 6, 2025
Merged
fix(ast): estree compat MemberExpression#8921overlookmotel merged 12 commits intooxc-project:mainfrom
MemberExpression#8921overlookmotel merged 12 commits intooxc-project:mainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #8921 will not alter performanceComparing Summary
|
overlookmotel
approved these changes
Feb 6, 2025
Member
overlookmotel
left a comment
There was a problem hiding this comment.
I've pushed a few commits purely for code style nits. I'll follow up with a PR for more substantive changes. But yes, nice! We need an #[estree(add_entry)] attribute. This will be useful for other types too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2854
I added a bit weird macro
add_entry(computed = true)to add constant. Likely this is not the best way. I would appreciate any suggestion for a better approach 🙏